Tomas Lukosius added a comment - 23/Feb/10 09:56 AM There is synchronization on local variable 'monitor':
protected boolean accept(BlobDetails obj) {
synchronized (this.monitor) {
if (seenKeys.contains(obj.getName())) {
return false;
}
seenKeys.add(obj.getName());
return true;
}
}
I think synchronization on instance would give same effect:
protected synchronized boolean accept(BlobDetails obj) {
if (seenKeys.contains(obj.getName())) {
return false;
}
seenKeys.add(obj.getName());
return true;
}
Task
Resolved
Major
Thread safeness for AcceptOnceBlobNameFilter
protected boolean accept(BlobDetails obj) {
synchronized (this.monitor) {
if (seenKeys.contains(obj.getName())) { return false; }
seenKeys.add(obj.getName());
return true;
}
}
I think synchronization on instance would give same effect:
protected synchronized boolean accept(BlobDetails obj) {
if (seenKeys.contains(obj.getName())) { return false; }
seenKeys.add(obj.getName());
return true;
}